[ET-VK] Implement generic reduction shader + mean, sum, amax, amin #6457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context Introduce a generic shader to compute reduction along a single dim, and `keepdim = True`. With the generic shader template, `mean`, `sum`, `amin`, and `amax` can be implemented. Differential Revision: [D64840504](https://our.internmc.facebook.com/intern/diff/D64840504/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6457
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit b0552f6 with merge base 169ddbf ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64840504 |
SS-JIA
added a commit
that referenced
this pull request
Oct 23, 2024
## Context Introduce a generic shader to compute reduction along a single dim, and `keepdim = True`. With the generic shader template, `mean`, `sum`, `amin`, and `amax` can be implemented. Differential Revision: [D64840504](https://our.internmc.facebook.com/intern/diff/D64840504/) ghstack-source-id: 249629739 Pull Request resolved: #6457
…ax, amin" ## Context Introduce a generic shader to compute reduction along a single dim, and `keepdim = True`. With the generic shader template, `mean`, `sum`, `amin`, and `amax` can be implemented. Differential Revision: [D64840504](https://our.internmc.facebook.com/intern/diff/D64840504/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Oct 23, 2024
Pull Request resolved: #6457 ## Context Introduce a generic shader to compute reduction along a single dim, and `keepdim = True`. With the generic shader template, `mean`, `sum`, `amin`, and `amax` can be implemented. ghstack-source-id: 249648443 @exported-using-ghexport Differential Revision: [D64840504](https://our.internmc.facebook.com/intern/diff/D64840504/)
|
This pull request was exported from Phabricator. Differential Revision: D64840504 |
jorgep31415
approved these changes
Oct 23, 2024
…ax, amin" ## Context Introduce a generic shader to compute reduction along a single dim, and `keepdim = True`. With the generic shader template, `mean`, `sum`, `amin`, and `amax` can be implemented. Differential Revision: [D64840504](https://our.internmc.facebook.com/intern/diff/D64840504/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64840504 |
SS-JIA
added a commit
that referenced
this pull request
Oct 23, 2024
Pull Request resolved: #6457 ## Context Introduce a generic shader to compute reduction along a single dim, and `keepdim = True`. With the generic shader template, `mean`, `sum`, `amin`, and `amax` can be implemented. ghstack-source-id: 249659867 @exported-using-ghexport Differential Revision: [D64840504](https://our.internmc.facebook.com/intern/diff/D64840504/)
…ax, amin" ## Context Introduce a generic shader to compute reduction along a single dim, and `keepdim = True`. With the generic shader template, `mean`, `sum`, `amin`, and `amax` can be implemented. Differential Revision: [D64840504](https://our.internmc.facebook.com/intern/diff/D64840504/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64840504 |
SS-JIA
added a commit
that referenced
this pull request
Oct 23, 2024
Pull Request resolved: #6457 ## Context Introduce a generic shader to compute reduction along a single dim, and `keepdim = True`. With the generic shader template, `mean`, `sum`, `amin`, and `amax` can be implemented. ghstack-source-id: 249709743 @exported-using-ghexport Differential Revision: [D64840504](https://our.internmc.facebook.com/intern/diff/D64840504/)
facebook-github-bot
merged commit f26a66e
into
gh/SS-JIA/127/base
43 of 46 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Oct 24, 2024
…6473) Pull Request resolved: #6457 ## Context Introduce a generic shader to compute reduction along a single dim, and `keepdim = True`. With the generic shader template, `mean`, `sum`, `amin`, and `amax` can be implemented. ghstack-source-id: 249709743 @exported-using-ghexport Differential Revision: [D64840504](https://our.internmc.facebook.com/intern/diff/D64840504/) --------- Co-authored-by: Stephen Jia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
Introduce a generic shader to compute reduction along a single dim, and
keepdim = True. With the generic shader template,mean,sum,amin, andamaxcan be implemented.Differential Revision: D64840504